Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[57] get and clean images #84

Merged
merged 10 commits into from
Dec 8, 2023
Merged

[57] get and clean images #84

merged 10 commits into from
Dec 8, 2023

Conversation

nicolaes
Copy link
Contributor

@nicolaes nicolaes commented Dec 2, 2023 •
edited
Loading

What does it fix?

Closes #57 : additional suggestions
This includes PR #83.

How has it been tested?

Get uploaded image

GET https://localhost:5001/file/eb8749f3-05a5-4d07-9310-056a2c7ef37d
(id taken from singleUpload mutation response, see testing on #83)

Create theme with an uploaded image

mutation {
  themeCreate(input: { title: "New Theme 4", fileBlobId: "eb8749f3-05a5-4d07-9310-056a2c7ef37d" }) {
    theme {
      id
      title
      thumbnail {
          url,
          fileBlobId
      }
    }
  }
}

New query to get recentImageUploads

{
    recentImageUploads(limit: 2) {
        id,
        createdAt
    }
}

Hangfire cleanup

  1. Created new upload with singleUpload mutation
  2. Manipulated cron frequency in Startup.cs to Minutely and parameters of DeleteOldEntries in FileBlobRepository, to account for more database entries (can also be done by moving CreatedOn column to a few days ago)
  3. Started app and verified orphan entries are removed and dependent entries are not (console logged how many entries were deleted)

@nicolaes nicolaes marked this pull request as ready for review December 4, 2023 09:47
@nicolaes nicolaes mentioned this pull request Dec 4, 2023
Closed
@nicolaes nicolaes changed the title Feature/57 get and clean images [57] get and clean images Dec 7, 2023
idormenco
idormenco approved these changes Dec 7, 2023
View reviewed changes
TeacherWorkout.Domain/Themes/CreateTheme.cs Outdated Show resolved Hide resolved
idormenco
idormenco approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@idormenco idormenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idormenco idormenco merged commit 4158a36 into code4romania:develop Dec 8, 2023
2 checks passed
@nicolaes nicolaes deleted the feature/57-get-and-clean-images branch December 8, 2023 12:24
@nicolaes nicolaes mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielferecatu danielferecatu danielferecatu approved these changes

@idormenco idormenco idormenco approved these changes

@pirvudoru pirvudoru Awaiting requested review from pirvudoru pirvudoru is a code owner

@alexandru-calinoiu alexandru-calinoiu Awaiting requested review from alexandru-calinoiu alexandru-calinoiu is a code owner

@catileptic catileptic Awaiting requested review from catileptic catileptic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for uploading an image
3 participants
@nicolaes @idormenco @danielferecatu